Repository navigation
Make local an explicit baseUrl exception - #7
Merged
Merged
Conversation
`baseUrl` must equal `/<codedApp.name>/` was written as an absolute, and four of the five repos broke it: their `local` targets use `baseUrl: "/"` against a `<slug>-workshop-local` app name. Only `workshop-ixp` complied, at `/ixp-workshop-local/`. The four were right and the rule was overstated. It exists so a build and a deploy cannot disagree about where assets live -- Docusaurus compiles `baseUrl` into every asset path and the app is served at `/<name>/`. `local` is never deployed, so there is no deploy to disagree with, and `/` is what makes `npm run start` serve at the root of localhost. The rule now binds hosted targets and names `local` as the exception. It also moves into its own bullet: it was buried in the middle of the slug-budget arithmetic, which is a separate concern and read as an aside rather than a rule. `workshop-ixp` moves to `/` in its own repo so all five agree. Release v1.7.1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
baseUrlmust equal/<codedApp.name>/was written as an absolute, and four of thefive repos broke it: their
localtargets usebaseUrl: "/"against a<slug>-workshop-localapp name. Onlyworkshop-ixpcomplied.The four were right and the rule was overstated. It exists so a build and a deploy
cannot disagree about where assets live;
localis never deployed, so there is nodeploy to disagree with, and
/is what makesnpm run startserve at the root oflocalhost.
The rule now binds hosted targets and names
localas the exception. It also movesinto its own bullet — it was buried mid-way through the slug-budget arithmetic, a
separate concern, and read as an aside rather than a rule.
Includes the
Release v1.7.1bump so the five content repos can repin.🤖 Generated with Claude Code